Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3599)

Unified Diff: blimp/engine/browser_tests/input_browsertest.cc

Issue 2393043004: Blimp: IME should submit form with text (Closed)
Patch Set: Bundled IME params into a struct Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/browser_tests/input_browsertest.cc
diff --git a/blimp/engine/browser_tests/input_browsertest.cc b/blimp/engine/browser_tests/input_browsertest.cc
index 777dc0a7745eea853b8025e7bae26846de2b45d4..a73458990ea81d2c78dd22233992d8e019e6fdb8 100644
--- a/blimp/engine/browser_tests/input_browsertest.cc
+++ b/blimp/engine/browser_tests/input_browsertest.cc
@@ -120,14 +120,14 @@ IN_PROC_BROWSER_TEST_F(InputBrowserTest, InputText) {
blink::WebGestureEvent event;
event.type = blink::WebInputEvent::Type::GestureTap;
- client::ImeFeature::ShowImeCallback callback;
+ client::ImeFeature::WebInputRequest request;
// Send a tap event from the client and expect the IME dialog to show.
- EXPECT_CALL(client_ime_feature_delegate_, OnShowImeRequested(_, "", _))
+ EXPECT_CALL(client_ime_feature_delegate_, OnShowImeRequested(_))
.Times(AtLeast(1))
.WillOnce(
DoAll(InvokeWithoutArgs(this, &InputBrowserTest::SignalCompletion),
- SaveArg<2>(&callback)));
+ SaveArg<0>(&request)));
client_session_->GetRenderWidgetFeature()->SendWebGestureEvent(kDummyTabId, 1,
event);
RunAndVerify();
@@ -136,7 +136,11 @@ IN_PROC_BROWSER_TEST_F(InputBrowserTest, InputText) {
// the page title.
EXPECT_CALL(client_nav_feature_delegate_, OnTitleChanged(kDummyTabId, "test"))
.WillOnce(InvokeWithoutArgs(this, &InputBrowserTest::SignalCompletion));
- callback.Run("test");
+
+ client::ImeFeature::WebInputResponse response(request);
+ response.text = "test";
+ client_session_->GetImeFeature()->OnImeTextEntered(response);
+
RunAndVerify();
}

Powered by Google App Engine
This is Rietveld 408576698