Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2393043002: [SPInvalidation] Enable LayoutEmbeddedObject paint invalidation in new path (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Enable LayoutEmbeddedObject paint invalidation in new path This fixes plugins/webview-plugin-lifecycle.html and plugins/webview-plugin-nested-iframe-scroll.html for slimmingPaintInvalidation. BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/a6bc2b51c4fb4d09a762fc0b7c27c833c2d49787 Cr-Commit-Position: refs/heads/master@{#423625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp View 3 chunks +7 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.h View 1 chunk +7 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xianzhu
4 years, 2 months ago (2016-10-05 15:46:37 UTC) #7
chrishtr
lgtm
4 years, 2 months ago (2016-10-06 17:51:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393043002/1
4 years, 2 months ago (2016-10-06 17:51:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 19:23:00 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 19:25:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6bc2b51c4fb4d09a762fc0b7c27c833c2d49787
Cr-Commit-Position: refs/heads/master@{#423625}

Powered by Google App Engine
This is Rietveld 408576698