Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: dart/runtime/bin/vmservice_impl.h

Issue 239303004: Extract common code, add host IP to --debug and --enable-vm-service options (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/runtime/bin/vmservice/vmservice_io.dart ('k') | dart/runtime/bin/vmservice_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/bin/vmservice_impl.h
diff --git a/dart/runtime/bin/vmservice_impl.h b/dart/runtime/bin/vmservice_impl.h
index 8ca7233eda91e55e0e2fe785f27f844e40e93929..b49809edb602679aa3675a2302a8e9e358769c05 100644
--- a/dart/runtime/bin/vmservice_impl.h
+++ b/dart/runtime/bin/vmservice_impl.h
@@ -15,12 +15,12 @@ namespace bin {
class VmService {
public:
// Returns false if service could not be started.
- static bool Start(intptr_t server_port);
+ static bool Start(const char *server_ip, intptr_t server_port);
// Error message if startup failed.
static const char* GetErrorMessage();
private:
- static bool _Start(intptr_t server_port);
+ static bool _Start(const char *server_ip, intptr_t server_port);
static Dart_Handle GetSource(const char* name);
static Dart_Handle LoadScript(const char* name);
static Dart_Handle LoadSource(Dart_Handle library, const char* name);
« no previous file with comments | « dart/runtime/bin/vmservice/vmservice_io.dart ('k') | dart/runtime/bin/vmservice_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698