Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 239303003: Add devtools trace event for event dispatching (Closed)

Created:
6 years, 8 months ago by yurys
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, loislo
CC:
blink-reviews
Visibility:
Public.

Description

Add devtools trace event for event dispatching Current implementation of InspectorTimelineAgent will emit EventDispatch event only if there is at least one handler on the event's path. After this patch EventDispather::dispatch trace events will be sent for unhandled events too. We should be able to filter out such events later on the front-end side and avoid additional checks at the instrumentation point. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171951

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
A LayoutTests/inspector-protocol/timeline/timeline-dispatchEvent.html View 1 2 3 4 1 chunk +96 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/timeline/timeline-dispatchEvent-expected.txt View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/events/EventDispatcher.cpp View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 8 months ago (2014-04-15 16:19:25 UTC) #1
pfeldman
Lets introduce a test suite that would provide the coverage for devtools-timeline right away. https://chromiumcodereview.appspot.com/239303003/diff/60001/Source/core/events/EventDispatcher.cpp ...
6 years, 8 months ago (2014-04-16 09:01:18 UTC) #2
yurys
Added protocol test for the new tracing events. https://codereview.chromium.org/239303003/diff/60001/Source/core/events/EventDispatcher.cpp File Source/core/events/EventDispatcher.cpp (right): https://codereview.chromium.org/239303003/diff/60001/Source/core/events/EventDispatcher.cpp#newcode116 Source/core/events/EventDispatcher.cpp:116: TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools-timeline"), ...
6 years, 8 months ago (2014-04-18 13:38:52 UTC) #3
pfeldman
lgtm
6 years, 8 months ago (2014-04-18 13:41:43 UTC) #4
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-18 14:47:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/239303003/80001
6 years, 8 months ago (2014-04-18 14:47:35 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 16:00:33 UTC) #7
Message was sent while issue was closed.
Change committed as 171951

Powered by Google App Engine
This is Rietveld 408576698