Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2393013002: reflow comments in core/{clipboard,streams,testing,timing} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
jbroman
CC:
blink-reviews, chromium-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/{clipboard,streams,testing,timing} BUG=563793 Committed: https://crrev.com/bc70ee84f5dc0a2d791c4f650314cb3fd8d7bd26 Cr-Commit-Position: refs/heads/master@{#423200}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments (heh!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -87 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectItem.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.h View 3 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 7 chunks +20 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/Pasteboard.h View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamController.h View 1 4 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/streams/Stream.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.h View 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 4 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 5 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/MemoryInfo.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTiming.cpp View 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Nico
4 years, 2 months ago (2016-10-04 20:32:58 UTC) #4
jbroman
https://codereview.chromium.org/2393013002/diff/1/third_party/WebKit/Source/core/streams/ReadableStreamController.h File third_party/WebKit/Source/core/streams/ReadableStreamController.h (right): https://codereview.chromium.org/2393013002/diff/1/third_party/WebKit/Source/core/streams/ReadableStreamController.h#newcode78 third_party/WebKit/Source/core/streams/ReadableStreamController.h:78: ScriptState::Scope scope(scriptState); // will assert context is valid; do ...
4 years, 2 months ago (2016-10-04 21:09:48 UTC) #5
Nico
Thanks! https://codereview.chromium.org/2393013002/diff/1/third_party/WebKit/Source/core/streams/ReadableStreamController.h File third_party/WebKit/Source/core/streams/ReadableStreamController.h (right): https://codereview.chromium.org/2393013002/diff/1/third_party/WebKit/Source/core/streams/ReadableStreamController.h#newcode78 third_party/WebKit/Source/core/streams/ReadableStreamController.h:78: ScriptState::Scope scope(scriptState); // will assert context is valid; ...
4 years, 2 months ago (2016-10-04 21:13:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393013002/20001
4 years, 2 months ago (2016-10-04 21:14:06 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-04 21:14:07 UTC) #10
Nico
jbroman: looks like i still need an lgtm here
4 years, 2 months ago (2016-10-05 15:22:19 UTC) #11
jbroman
whoops, my bad lgtm
4 years, 2 months ago (2016-10-05 15:23:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393013002/20001
4 years, 2 months ago (2016-10-05 15:23:38 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 17:19:02 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 17:21:16 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc70ee84f5dc0a2d791c4f650314cb3fd8d7bd26
Cr-Commit-Position: refs/heads/master@{#423200}

Powered by Google App Engine
This is Rietveld 408576698