Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2393003003: DevTools: add a test for storage cleanup worker (Closed)

Created:
4 years, 2 months ago by caseq
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
jam, chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add a test for storage cleanup worker It did not have any test coverage in the browser and it's critical for DevTools to be able to save things to files. BUG=652937 Committed: https://crrev.com/cb5ed93a66692ba25f8fe57559a4b8e67401c165 Cr-Commit-Position: refs/heads/master@{#423300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caseq
4 years, 2 months ago (2016-10-05 19:11:32 UTC) #2
pfeldman
lgtm
4 years, 2 months ago (2016-10-05 19:12:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393003003/1
4 years, 2 months ago (2016-10-05 19:12:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 21:37:25 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 21:39:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb5ed93a66692ba25f8fe57559a4b8e67401c165
Cr-Commit-Position: refs/heads/master@{#423300}

Powered by Google App Engine
This is Rietveld 408576698