[rAc] Reset the user's selection to the new default when the default Wallet item changes.

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 2267 matching lines @@
 TEST_F(AutofillDialogControllerTest, GeneratedCardBubbleShown) {
   EXPECT_CALL(*test_generated_bubble_controller(), SetupAndShow(_, _)).Times(1);
 
   SubmitWithWalletItems(CompleteAndValidWalletItems());
   controller()->OnDidGetFullWallet(wallet::GetTestFullWallet());
   controller()->ViewClosed();
 
   EXPECT_EQ(0, mock_new_card_bubble_controller()->bubbles_shown());
 }
 
+// Verify that new Wallet data is fetched when the user switches away from the
+// tab hosting the Autofill dialog and back. Also verify that the user's
+// selection is preserved across this re-fetch.
 TEST_F(AutofillDialogControllerTest, ReloadWalletItemsOnActivation) {
   // Switch into Wallet mode and initialize some Wallet data.
   SwitchToWallet();
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestNonDefaultShippingAddress());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
 
   // Initially, the default entries should be selected.
   ui::MenuModel* cc_billing_model =
       controller()->MenuModelForSection(SECTION_CC_BILLING);
   ui::MenuModel* shipping_model =
       controller()->MenuModelForSection(SECTION_SHIPPING);
   // "add", "manage", and 2 suggestions.
   ASSERT_EQ(4, cc_billing_model->GetItemCount());
   EXPECT_TRUE(cc_billing_model->IsItemCheckedAt(0));
   // "use billing", "add", "manage", and 2 suggestions.
   ASSERT_EQ(5, shipping_model->GetItemCount());
   EXPECT_TRUE(shipping_model->IsItemCheckedAt(2));
 
   // Select entries other than the defaults.
   cc_billing_model->ActivatedAt(1);
   shipping_model->ActivatedAt(1);
-  // "add", "manage", and 2 suggestions.
+  // 2 suggestions, "add", and "manage".
   ASSERT_EQ(4, cc_billing_model->GetItemCount());
   EXPECT_TRUE(cc_billing_model->IsItemCheckedAt(1));
-  // "use billing", "add", "manage", and 2 suggestions.
+  // "use billing", 2 suggestions, "add", "manage".
   ASSERT_EQ(5, shipping_model->GetItemCount());
   EXPECT_TRUE(shipping_model-> IsItemCheckedAt(1));
 
   // Simulate switching away from the tab and back.  This should issue a request
   // for wallet items.
   EXPECT_CALL(*controller()->GetTestingWalletClient(), GetWalletItems(_));
   controller()->TabActivated();
 
   // Simulate a response that includes different items.
   wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrumentExpired());
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestNonDefaultShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
 
   // The previously selected entries should still be selected.
-  // "add", "manage", and 3 suggestions.
+  // 3 suggestions, "add", and "manage".
   ASSERT_EQ(5, cc_billing_model->GetItemCount());
   EXPECT_TRUE(cc_billing_model->IsItemCheckedAt(2));
-  // "use billing", "add", "manage", and 1 suggestion.
+  // "use billing", 1 suggestion, "add", and "manage".
   ASSERT_EQ(4, shipping_model->GetItemCount());
   EXPECT_TRUE(shipping_model->IsItemCheckedAt(1));
 }
 
+// Verify that if the default values change when re-fetching Wallet data, these
+// new default values are selected in the dialog.
+TEST_F(AutofillDialogControllerTest,
+       ReloadWalletItemsOnActivationWithNewDefaults) {
+  // Switch into Wallet mode and initialize some Wallet data.
+  SwitchToWallet();
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
+  wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
+  wallet_items->AddAddress(wallet::GetTestNonDefaultShippingAddress());
+  wallet_items->AddAddress(wallet::GetTestShippingAddress());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  // Initially, the default entries should be selected.
+  ui::MenuModel* cc_billing_model =
+      controller()->MenuModelForSection(SECTION_CC_BILLING);
+  ui::MenuModel* shipping_model =
+      controller()->MenuModelForSection(SECTION_SHIPPING);
+  // 2 suggestions, "add", and "manage".
+  ASSERT_EQ(4, cc_billing_model->GetItemCount());
+  EXPECT_TRUE(cc_billing_model->IsItemCheckedAt(0));
+  // "use billing", 2 suggestions, "add", and "manage".
+  ASSERT_EQ(5, shipping_model->GetItemCount());
+  EXPECT_TRUE(shipping_model->IsItemCheckedAt(2));
+
+  // Simulate switching away from the tab and back.  This should issue a request
+  // for wallet items.
+  EXPECT_CALL(*controller()->GetTestingWalletClient(), GetWalletItems(_));
+  controller()->TabActivated();
+
+  // Simulate a response that includes different default values.
+  wallet_items =
+      wallet::GetTestWalletItemsWithDefaultIds("new_default_instrument_id",
+                                               "new_default_address_id");
+  scoped_ptr<wallet::Address> other_address = wallet::GetTestShippingAddress();
+  other_address->set_object_id("other_address_id");
+  scoped_ptr<wallet::Address> new_default_address =
+      wallet::GetTestNonDefaultShippingAddress();
+  new_default_address->set_object_id("new_default_address_id");
+
+  wallet_items->AddInstrument(
+      wallet::GetTestMaskedInstrumentWithId("other_instrument_id"));
+  wallet_items->AddInstrument(
+      wallet::GetTestMaskedInstrumentWithId("new_default_instrument_id"));
+  wallet_items->AddAddress(new_default_address.Pass());
+  wallet_items->AddAddress(other_address.Pass());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  // The new default entries should be selected.
+  // 2 suggestions, "add", and "manage".
+  ASSERT_EQ(4, cc_billing_model->GetItemCount());
+  EXPECT_TRUE(cc_billing_model->IsItemCheckedAt(1));
+  // "use billing", 2 suggestions, "add", and "manage".
+  ASSERT_EQ(5, shipping_model->GetItemCount());
+  EXPECT_TRUE(shipping_model->IsItemCheckedAt(1));
+}
+
 TEST_F(AutofillDialogControllerTest, ReloadWithEmptyWalletItems) {
   SwitchToWallet();
 
   controller()->OnDidGetWalletItems(CompleteAndValidWalletItems());
   controller()->MenuModelForSection(SECTION_CC_BILLING)->ActivatedAt(1);
   controller()->MenuModelForSection(SECTION_SHIPPING)->ActivatedAt(1);
 
   EXPECT_CALL(*controller()->GetTestingWalletClient(), GetWalletItems(_));
   controller()->TabActivated();
 
   controller()->OnDidGetWalletItems(wallet::GetTestWalletItems());
 
   EXPECT_FALSE(controller()->MenuModelForSection(SECTION_CC_BILLING));
   EXPECT_EQ(
       3, controller()->MenuModelForSection(SECTION_SHIPPING)->GetItemCount());
 }
 
 }  // namespace autofill