Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2392983002: Deprecate analysis option "cacheSize". (Closed)

Created:
4 years, 2 months ago by Paul Berry
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate analysis option "cacheSize". This option has had no effect for quite some time. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f5ed63f2bef744348136a85ac17c9d4cb98b551c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 2 months ago (2016-10-04 16:46:15 UTC) #2
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-04 16:47:49 UTC) #3
Paul Berry
4 years, 2 months ago (2016-10-04 16:54:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5ed63f2bef744348136a85ac17c9d4cb98b551c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698