Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 239293002: Remove assertion scopes from V8_Fatal (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Remove assertion scopes from V8_Fatal V8_Fatal no longer tries to print a js stack, so we don't need those scopes BUG=none R=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/checks.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-15 15:16:50 UTC) #1
Yang
On 2014/04/15 15:16:50, jochen wrote: Lgtm
6 years, 8 months ago (2014-04-15 15:20:19 UTC) #2
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-15 15:38:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698