Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2392903003: Fix window_features.mojom Blink traits dependency (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix window_features.mojom Blink traits dependency The traits impl was depending on the wrong generator target, leading to potential build flag. BUG=652779 TBR=haraken@chromium.org Committed: https://crrev.com/a6d9f1684e068e90f0fbdd00ea61fc99ba530561 Cr-Commit-Position: refs/heads/master@{#422925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392903003/1
4 years, 2 months ago (2016-10-04 19:16:44 UTC) #5
dcheng
LGTM
4 years, 2 months ago (2016-10-04 19:19:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 20:57:47 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:59:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6d9f1684e068e90f0fbdd00ea61fc99ba530561
Cr-Commit-Position: refs/heads/master@{#422925}

Powered by Google App Engine
This is Rietveld 408576698