Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 23929006: remove remaining uses of default isolate in tests (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove remaining uses of default isolate in tests R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16858

Patch Set 1 #

Patch Set 2 : fix serializer tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -66 lines) Patch
M test/cctest/cctest.h View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/cctest.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 9 chunks +14 lines, -10 lines 0 comments Download
M test/cctest/test-debug.cc View 12 chunks +16 lines, -14 lines 0 comments Download
M test/cctest/test-lockers.cc View 4 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-log.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 15 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/test-threads.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-20 08:59:24 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-20 10:37:47 UTC) #2
dcarney
7 years, 3 months ago (2013-09-20 10:52:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16858 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698