Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2392893002: Remove PermissionController.* files (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
Reviewers:
foolip
CC:
blink-reviews, chromium-reviews, haraken, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PermissionController.* files It is no longer compiled. BUG=None Committed: https://crrev.com/8839f04cc3f41178379a0530f75a7567ae3958c6 Cr-Commit-Position: refs/heads/master@{#422770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -96 lines) Patch
D third_party/WebKit/Source/modules/permissions/PermissionController.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/modules/permissions/PermissionController.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mlamouri (slow - plz ping)
4 years, 2 months ago (2016-10-04 11:15:52 UTC) #2
foolip
lgtm
4 years, 2 months ago (2016-10-04 12:08:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392893002/1
4 years, 2 months ago (2016-10-04 12:08:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 13:29:18 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 13:31:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8839f04cc3f41178379a0530f75a7567ae3958c6
Cr-Commit-Position: refs/heads/master@{#422770}

Powered by Google App Engine
This is Rietveld 408576698