Issue 2392873002: Use largest supported date for cookies if timegm overflows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2392873002: Use largest supported date for cookies if timegm overflows

Created:
4 years, 2 months ago by landell

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use largest supported date for cookies if timegm overflows Regression CL: https://codereview.chromium.org/1988663002 If a too large date is given to timegm the result might overflow. This is problematic on platforms that have time_t as 32-bit signed integers. Before the change, the largest possible value was returned which works well with large cookie expiration dates. Now a null Time is returned which makes cookies non persistent. BUG=652627

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -1 line)			Patch
M	base/time/time.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/time/time_posix.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	net/cookies/cookie_util.cc	View	1 chunk	+10 lines, -1 line	0 comments	Download