Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 239283010: Fix subpixel font scaling for DirectWrite (Closed)

Created:
6 years, 8 months ago by eae
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Fix subpixel font scaling for DirectWrite Implement support for subpixel font scaling for the Windows DirectWrite backend and change how the subpixel flag is set to use the SkPaint:: kSubpixelText_Flag flag instead of the method as otherwise the setFlags call clears the subpixel flag. BUG=25541 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171817

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +178 lines, -5 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eae
6 years, 8 months ago (2014-04-16 22:36:16 UTC) #1
eae
On 2014/04/16 22:36:16, eae wrote: Image diffs: https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/4103/layout-test-results/results.html
6 years, 8 months ago (2014-04-16 22:44:14 UTC) #2
leviw_travelin_and_unemployed
On 2014/04/16 22:44:14, eae wrote: > On 2014/04/16 22:36:16, eae wrote: > > Image diffs: ...
6 years, 8 months ago (2014-04-16 22:48:00 UTC) #3
eae
> Code change looks great, but I did find one test that's failing: > virtual/windows-directwrite/fast/text/shaping/shaping-selection-rect.html ...
6 years, 8 months ago (2014-04-16 22:52:34 UTC) #4
leviw_travelin_and_unemployed
lgtm
6 years, 8 months ago (2014-04-16 22:58:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/239283010/20001
6 years, 8 months ago (2014-04-16 22:59:33 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 23:59:27 UTC) #7
Message was sent while issue was closed.
Change committed as 171817

Powered by Google App Engine
This is Rietveld 408576698