Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/common/extensions/api/PRESUBMIT.py

Issue 239283008: Add global presubmit that JSON and IDL files can be parsed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT_test.py ('k') | chrome/common/extensions/api/PRESUBMIT_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/PRESUBMIT.py
diff --git a/chrome/common/extensions/api/PRESUBMIT.py b/chrome/common/extensions/api/PRESUBMIT.py
deleted file mode 100644
index 771f7fdc9bf65ef1e8c575c110ee3d7e58d9c672..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/api/PRESUBMIT.py
+++ /dev/null
@@ -1,72 +0,0 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-def _GetJSONParseError(input_api, filename):
- try:
- contents = input_api.ReadFile(filename)
- json_comment_eater = input_api.os_path.join(
- input_api.PresubmitLocalPath(),
- '..', '..', '..', '..', 'tools',
- 'json_comment_eater', 'json_comment_eater.py')
- process = input_api.subprocess.Popen(
- [input_api.python_executable, json_comment_eater],
- stdin=input_api.subprocess.PIPE,
- stdout=input_api.subprocess.PIPE,
- universal_newlines=True)
- (nommed, _) = process.communicate(input=contents)
- input_api.json.loads(nommed)
- except ValueError as e:
- return e
- return None
-
-
-def _GetIDLParseError(input_api, filename):
- idl_schema = input_api.os_path.join(
- input_api.PresubmitLocalPath(),
- '..', '..', '..', '..', 'tools',
- 'json_schema_compiler', 'idl_schema.py')
- process = input_api.subprocess.Popen(
- [input_api.python_executable, idl_schema, filename],
- stdout=input_api.subprocess.PIPE,
- stderr=input_api.subprocess.PIPE,
- universal_newlines=True)
- (_, error) = process.communicate()
- return error or None
-
-
-def _GetParseErrors(input_api, output_api):
- # Run unit tests.
- results = []
- if input_api.AffectedFiles(
- file_filter=lambda f: 'PRESUBMIT' in f.LocalPath()):
- results = input_api.canned_checks.RunUnitTestsInDirectory(
- input_api, output_api, '.', whitelist=[r'^PRESUBMIT_test\.py$'])
-
- actions = {
- '.idl': _GetIDLParseError,
- '.json': _GetJSONParseError,
- }
-
- def get_action(affected_file):
- filename = affected_file.LocalPath()
- return actions.get(input_api.os_path.splitext(filename)[1])
-
- for affected_file in input_api.AffectedFiles(
- file_filter=
- lambda f: "test_presubmit" not in f.LocalPath() and get_action(f),
- include_deletes=False):
- parse_error = get_action(affected_file)(input_api,
- affected_file.AbsoluteLocalPath())
- if parse_error:
- results.append(output_api.PresubmitError('%s could not be parsed: %s' %
- (affected_file.LocalPath(), parse_error)))
- return results
-
-
-def CheckChangeOnUpload(input_api, output_api):
- return _GetParseErrors(input_api, output_api)
-
-
-def CheckChangeOnCommit(input_api, output_api):
- return _GetParseErrors(input_api, output_api)
« no previous file with comments | « PRESUBMIT_test.py ('k') | chrome/common/extensions/api/PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698