third_party/WebKit/Source/core/input/GestureManager.cpp - Issue 2392773002: Reenable framebusting deprecation, change it to allow navigation if iframe has ever had a user gestu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/GestureManager.cpp

Issue 2392773002: Reenable framebusting deprecation, change it to allow navigation if iframe has ever had a user gestu (Closed)

Patch Set: Fix faliing content_browsertest Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/GestureManager.cpp

diff --git a/third_party/WebKit/Source/core/input/GestureManager.cpp b/third_party/WebKit/Source/core/input/GestureManager.cpp

index 4151b5b0ab23efe7aa8ce94feb70f1e07093ab50..3912e9c2f7f9e248d5ad1adaa71084747b979be5 100644

--- a/third_party/WebKit/Source/core/input/GestureManager.cpp

+++ b/third_party/WebKit/Source/core/input/GestureManager.cpp

@@ -71,6 +71,7 @@ HitTestRequest::HitTestRequestType GestureManager::getHitTypeForGestureType(

WebInputEventResult GestureManager::handleGestureEventInFrame(

const GestureEventWithHitTestResults& targetedEvent) {

DCHECK(!targetedEvent.event().isScrollEvent());

+ m_frame->document()->setHasReceivedUserGesture();

Node* eventTarget = targetedEvent.hitTestResult().innerNode();

const PlatformGestureEvent& gestureEvent = targetedEvent.event();