Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2392773002: Reenable framebusting deprecation, change it to allow navigation if iframe has ever had a user gestu (Closed)
Patch Set: Fix faliing content_browsertest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 37978b53d46c6f7d4accb8a2f205ea2b3e26b5d2..78de53b722008d758cbb56ab637e2d5dd001299b 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -7030,6 +7030,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
"parent.location = '%s');",
b_url.spec().c_str());
+ // Ensure the child has received a user gesture, so that it has permission
+ // to framebust.
+ SimulateMouseClick(
+ root->child_at(0)->current_frame_host()->GetRenderWidgetHost(), 1, 1);
TestFrameNavigationObserver frame_observer(root);
EXPECT_TRUE(ExecuteScript(root->child_at(0), script));
frame_observer.Wait();

Powered by Google App Engine
This is Rietveld 408576698