Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2392773002: Reenable framebusting deprecation, change it to allow navigation if iframe has ever had a user gestu (Closed)
Patch Set: TODOs and TouchEventmanager Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
index c60a3ee76c308c14bd275a356f3ff12a8b1d0e67..528dcf916efcdf59b05f6395f539004620c2eff2 100644
--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
@@ -104,7 +104,10 @@ WebInputEventResult KeyboardEventManager::keyEvent(
if (!node)
return WebInputEventResult::NotHandled;
+ // TODO(japhet): UserGestureIndicator should setHasReceivedUserGesture()
+ // on the Document.
UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
+ m_frame->document()->setHasReceivedUserGesture();
// In IE, access keys are special, they are handled after default keydown
// processing, but cannot be canceled - this is hard to match. On Mac OS X,

Powered by Google App Engine
This is Rietveld 408576698