Reenable framebusting deprecation, change it to allow navigation if iframe has ever had a user gestu

third_party/WebKit/Source/core/input/GestureManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/GestureManager.h"
 
 #include "core/dom/Document.h"
 #include "core/editing/SelectionController.h"
 #include "core/events/GestureEvent.h"
 #include "core/frame/FrameHost.h"
@@ skipping 121 matching lines @@
 
 WebInputEventResult GestureManager::handleGestureTap(
     const GestureEventWithHitTestResults& targetedEvent) {
   FrameView* frameView(m_frame->view());
   const PlatformGestureEvent& gestureEvent = targetedEvent.event();
   HitTestRequest::HitTestRequestType hitType =
       getHitTypeForGestureType(gestureEvent.type());
   uint64_t preDispatchDomTreeVersion = m_frame->document()->domTreeVersion();
   uint64_t preDispatchStyleVersion = m_frame->document()->styleVersion();
 
+  // TODO(japhet): UserGestureIndicator should setHasReceivedUserGesture()
+  // on the Document.
   UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);

[Rick Byers, 2016/10/06 16:26:47]

for really simple cases like this, perhaps we should just add the Document
argument to the UserGestureIndicator constructor and use it?  Then you only need
TODOs for the cases where you don't know the Document as UserGestureIndicator
construction time.

+  m_frame->document()->setHasReceivedUserGesture();
 
   HitTestResult currentHitTest = targetedEvent.hitTestResult();
 
   // We use the adjusted position so the application isn't surprised to see a
   // event with co-ordinates outside the target's bounds.
   IntPoint adjustedPoint =
       frameView->rootFrameToContents(gestureEvent.position());
 
   const unsigned modifiers = gestureEvent.getModifiers();
 
@@ skipping 265 matching lines @@
     return nullptr;
 
   return &m_frame->page()->frameHost();
 }
 
 double GestureManager::getLastShowPressTimestamp() const {
   return m_lastShowPressTimestamp;
 }
 
 }  // namespace blink