Sanitize unparcable intents

chrome/android/junit/src/org/chromium/chrome/browser/TestableChromeApplication.java

Index: chrome/android/junit/src/org/chromium/chrome/browser/TestableChromeApplication.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/TestableChromeApplication.java b/chrome/android/junit/src/org/chromium/chrome/browser/TestableChromeApplication.java
new file mode 100644
index 0000000000000000000000000000000000000000..a5d3fa0ba1ef0f04d7d5fec912a99cfc79780b1d
--- /dev/null
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/TestableChromeApplication.java
@@ -0,0 +1,17 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser;
+
+/**
+ * To make ChromeApplication unit testable, it can't execite ContentApplication's onTerminate,
+ * which interacts with its (in tests nonexistant) TracingController.

[Ted C, 2016/10/04 20:19:23]

This actually seems like a bug in ContentApplication.

If we were to add a mTracingController != null check in
ContentApplication#onTermiate, would that solve this problem as well?

[kraush, 2016/10/04 21:36:36]

Using BaseChromiumApplication actually fixes this and we don't need to override
this method any more.
When I originally wrote this there was a hard dependency on ChromeApplication,
but that seems to be gone.

I'll remove this override (and probably the class as a whole - not sure we need
it any more)

+ * Compared to a Mock, this class can be used within an @Config
+ */
+public class TestableChromeApplication extends ChromeApplication {
+    @Override
+    public void onTerminate() {
+        // Do nothing
+    }
+}