Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: src/objects.cc

Issue 239273002: Revert "Handlifying clients of StringTable, step 1." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 6a1bc8ee0cf9da327122cacb3308bf508b0bbc53..9cca2cab2e90c544868b5ec89beadbabcf70371b 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -10096,16 +10096,20 @@ bool JSFunction::PassesFilter(const char* raw_filter) {
}
-void Oddball::Initialize(Isolate* isolate,
- Handle<Oddball> oddball,
- const char* to_string,
- Handle<Object> to_number,
- byte kind) {
- Handle<String> internalized_to_string =
- isolate->factory()->InternalizeUtf8String(CStrVector(to_string));
- oddball->set_to_string(*internalized_to_string);
- oddball->set_to_number(*to_number);
- oddball->set_kind(kind);
+MaybeObject* Oddball::Initialize(Heap* heap,
+ const char* to_string,
+ Object* to_number,
+ byte kind) {
+ String* internalized_to_string;
+ { MaybeObject* maybe_string =
+ heap->InternalizeUtf8String(
+ CStrVector(to_string));
+ if (!maybe_string->To(&internalized_to_string)) return maybe_string;
+ }
+ set_to_string(internalized_to_string);
+ set_to_number(to_number);
+ set_kind(kind);
+ return this;
}
@@ -14423,10 +14427,6 @@ Dictionary<SeededNumberDictionary, SeededNumberDictionaryShape, uint32_t>::
template Handle<NameDictionary>
HashTable<NameDictionary, NameDictionaryShape, Name*>::
- New(Isolate*, int, MinimumCapacity, PretenureFlag);
-
-template Handle<NameDictionary>
-HashTable<NameDictionary, NameDictionaryShape, Name*>::
Shrink(Handle<NameDictionary>, Name* n);
template Handle<SeededNumberDictionary>
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698