mojo: Mark DataView readers as WARN_UNUSED_RESULT.

mojo: Mark DataView readers as WARN_UNUSED_RESULT.

It's important to check this return value to make sure that
deserialization actually succeeded.

BUG=652129
Committed: https://crrev.com/88622215affa898deaf1399711387289cd8ff8ed
Cr-Commit-Position: refs/heads/master@{#422681}

[dcheng, 2016-10-03 21:28:48]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 21:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-03 21:30:20]

dcheng@chromium.org changed reviewers:
+ rockot@chromium.org, tsepez@chromium.org

[dcheng, 2016-10-03 21:30:20]

I'm not sure if there are other routines I'm missing here: perhaps some of the
stuff in StringTraits, etc?

[Ken Rockot(use gerrit already), 2016-10-03 21:35:59]

LGTM

Yes we should also add this to all the specializations of StringTraits and
ArrayTraits in mojo/public/cpp/bidnings.

We should also enforce that every StructTraits<U,V>::Read has WARN_UNUSED_RESULT
set as well. This of course only covers the generated ones.

I guess we could add a presubmit for that and just update existing StructTraits
specializations by hand.

[commit-bot: I haz the power, 2016-10-03 21:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:50:37]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom Sepez, 2016-10-03 21:56:11]

RS LGTM

[dcheng, 2016-10-04 01:24:44]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-10-04 01:24:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2392713002/#ps20001
(title: "Fix attribute placement to appease gcc")

[commit-bot: I haz the power, 2016-10-04 01:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:51:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 02:54:17]

Description was changed from

==========
mojo: Mark DataView readers as WARN_UNUSED_RESULT.

It's important to check this return value to make sure that
deserialization actually succeeded.

BUG=652129
==========

to

==========
mojo: Mark DataView readers as WARN_UNUSED_RESULT.

It's important to check this return value to make sure that
deserialization actually succeeded.

BUG=652129

Committed: https://crrev.com/88622215affa898deaf1399711387289cd8ff8ed
Cr-Commit-Position: refs/heads/master@{#422681}
==========

[commit-bot: I haz the power, 2016-10-04 02:54:18]

Patchset 2 (id:??) landed as
https://crrev.com/88622215affa898deaf1399711387289cd8ff8ed
Cr-Commit-Position: refs/heads/master@{#422681}