Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2392703002: Add virtual test suite to test LayoutNG code with fast/block/basic layout tests (Closed)

Created:
4 years, 2 months ago by Gleb Lanbin
Modified:
4 years, 2 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add virtual test suite to test LayoutNG code with fast/block/basic layout tests For now mark all fast/block/basic tests with "Failure". This will be changed once crrev.com/2389823003 is submitted. BUG=635619 Committed: https://crrev.com/30abb79af10482813dc76c87ebc7b0793f33e44f Cr-Commit-Position: refs/heads/master@{#422629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/layout_ng/fast/block/basic/README.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Gleb Lanbin
4 years, 2 months ago (2016-10-03 21:23:56 UTC) #3
cbiesinger
Thanks! lgtm
4 years, 2 months ago (2016-10-03 21:24:43 UTC) #5
ikilpatrick
On 2016/10/03 21:24:43, cbiesinger wrote: > Thanks! lgtm lgtm
4 years, 2 months ago (2016-10-03 21:44:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392703002/1
4 years, 2 months ago (2016-10-04 00:05:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:33:55 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:36:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30abb79af10482813dc76c87ebc7b0793f33e44f
Cr-Commit-Position: refs/heads/master@{#422629}

Powered by Google App Engine
This is Rietveld 408576698