Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 23927005: Use 1ms CPU profiler sampling interval on Android by default (Closed)

Created:
7 years, 3 months ago by yurys
Modified:
7 years, 3 months ago
CC:
v8-dev, alph
Visibility:
Public.

Description

Use 1ms CPU profiler sampling interval on Android by default This CL changes default sampling interval on Android from 5ms to 1ms so that it is the same on all platforms. All perf tests on modern devices (Galaxy Nexus, Nexus 7) show that 1ms should be long enough for profiling on mobile devices. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
7 years, 3 months ago (2013-09-04 11:11:43 UTC) #1
Benedikt Meurer
What about older devices? 1ms is tough.
7 years, 3 months ago (2013-09-04 11:18:39 UTC) #2
loislo
lgtm
7 years, 3 months ago (2013-09-04 11:18:41 UTC) #3
yurys
On 2013/09/04 11:18:39, Benedikt Meurer wrote: > What about older devices? 1ms is tough. I ...
7 years, 3 months ago (2013-09-04 11:49:41 UTC) #4
Benedikt Meurer
LGTM
7 years, 3 months ago (2013-09-04 12:06:28 UTC) #5
yurys
Committed patchset #1 manually as r16526 (presubmit successful).
7 years, 3 months ago (2013-09-04 12:38:44 UTC) #6
Jakob Kummerow
7 years, 3 months ago (2013-09-04 12:46:05 UTC) #7
Message was sent while issue was closed.
The 5ms tick interval resulted in a significant overall performance boost back
when the runtime profiler based its optimization decisions on these ticks, and
1ms ticks made it way too aggressive compared to desktop ia32 machines.

Now that optimization decisions use a different mechanism, +1 to this CL. 1ms is
more appropriate for profiling.

Powered by Google App Engine
This is Rietveld 408576698