chrome/browser/ui/webui/voice_search_ui.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/voice_search_ui.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/voice_search_ui.cc

diff --git a/chrome/browser/ui/webui/voice_search_ui.cc b/chrome/browser/ui/webui/voice_search_ui.cc

index bdaa99d2e586606976273f5746186399304cfde8..2c05270d9a63d1cfb540eea7b4ca58c0fac0ced7 100644

--- a/chrome/browser/ui/webui/voice_search_ui.cc

+++ b/chrome/browser/ui/webui/voice_search_ui.cc

@@ -82,7 +82,7 @@ void AddPair16(base::ListValue* list,

std::unique_ptr<base::DictionaryValue> results(new base::DictionaryValue());

results->SetString("key", key);

results->SetString("value", value);

- list->Append(results.release());

+ list->Append(std::move(results));

}

void AddPair(base::ListValue* list,