chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/preferences_browsertest.cc ('k') | chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

diff --git a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

index df8493faeba4f89a0dd660ba621facb03b0a916f..cdf1595be754e2faf8468526e197ccba9e74638a 100644

--- a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

+++ b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h"

+#include <utility>

#include "base/bind.h"

#include "base/bind_helpers.h"

#include "base/command_line.h"

@@ -141,7 +143,7 @@ void ChangePictureHandler::SendDefaultImages() {

default_user_image::kDefaultImageWebsiteIDs[i]));

image_data->SetString("title",

default_user_image::GetDefaultImageDescription(i));

- image_urls.Append(image_data.release());

+ image_urls.Append(std::move(image_data));

}

CallJavascriptFunction("cr.webUIListenerCallback",

base::StringValue("default-images-changed"),