chromeos/network/network_state_handler_unittest.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state_handler_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: headers Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_state_handler_unittest.cc

diff --git a/chromeos/network/network_state_handler_unittest.cc b/chromeos/network/network_state_handler_unittest.cc

index 8c9245f150e22eae083a14dca659f9b841e488c1..73245ac3181d2593491674e85bf93b8b993af178 100644

--- a/chromeos/network/network_state_handler_unittest.cc

+++ b/chromeos/network/network_state_handler_unittest.cc

@@ -787,7 +787,7 @@ TEST_F(NetworkStateHandlerTest, IPConfigChanged) {

base::DictionaryValue ip_config_properties;

ip_config_test->AddIPConfig(kIPConfigPath, ip_config_properties);

base::ListValue device_ip_configs;

- device_ip_configs.Append(new base::StringValue(kIPConfigPath));

+ device_ip_configs.AppendString(kIPConfigPath);

device_test_->SetDeviceProperty(

kShillManagerClientStubWifiDevice, shill::kIPConfigsProperty,

device_ip_configs);