Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/dbus/shill_profile_client_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: headers Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc ('K') | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/network/network_state_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_profile_client_unittest.cc
diff --git a/chromeos/dbus/shill_profile_client_unittest.cc b/chromeos/dbus/shill_profile_client_unittest.cc
index 16876e9c63ea4ff632ab9f87f97548eb795d15e6..448343f3a584664473c50bf67000c36960eb1ea3 100644
--- a/chromeos/dbus/shill_profile_client_unittest.cc
+++ b/chromeos/dbus/shill_profile_client_unittest.cc
@@ -65,7 +65,7 @@ TEST_F(ShillProfileClientTest, PropertyChanged) {
// Set expectations.
base::ListValue value;
- value.Append(new base::StringValue(kExampleEntryPath));
+ value.AppendString(kExampleEntryPath);
MockPropertyChangeObserver observer;
EXPECT_CALL(observer,
OnPropertyChanged(
@@ -107,7 +107,7 @@ TEST_F(ShillProfileClientTest, GetProperties) {
// Create the expected value.
base::ListValue* entries = new base::ListValue;
- entries->Append(new base::StringValue(kExampleEntryPath));
+ entries->AppendString(kExampleEntryPath);
base::DictionaryValue value;
value.SetWithoutPathExpansion(shill::kEntriesProperty, entries);
// Set expectations.
« chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc ('K') | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/network/network_state_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698