Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chromeos/dbus/fake_gsm_sms_client.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: headers Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_gsm_sms_client.cc
diff --git a/chromeos/dbus/fake_gsm_sms_client.cc b/chromeos/dbus/fake_gsm_sms_client.cc
index 9a0f75a3183fa10425312356854753bd14d531a2..904470348d230c09f3454f9b6cefb4f58d1f5d0a 100644
--- a/chromeos/dbus/fake_gsm_sms_client.cc
+++ b/chromeos/dbus/fake_gsm_sms_client.cc
@@ -4,6 +4,9 @@
#include <stdint.h>
+#include <memory>
+#include <utility>
+
#include "base/bind.h"
#include "base/location.h"
#include "base/single_thread_task_runner.h"
@@ -103,12 +106,12 @@ void FakeGsmSMSClient::PushTestMessageDelayed() {
bool FakeGsmSMSClient::PushTestMessage() {
if (test_index_ >= static_cast<int>(test_messages_.size()))
return false;
- base::DictionaryValue* message = new base::DictionaryValue;
+ std::unique_ptr<base::DictionaryValue> message(new base::DictionaryValue);
message->SetString("number", "000-000-0000");
message->SetString("text", test_messages_[test_index_]);
message->SetInteger("index", test_index_);
int msg_index = message_list_.GetSize();
- message_list_.Append(message);
+ message_list_.Append(std::move(message));
if (!handler_.is_null())
handler_.Run(msg_index, true);
++test_index_;

Powered by Google App Engine
This is Rietveld 408576698