Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3212)

Unified Diff: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: headers Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
diff --git a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
index 27e1777497183e29a26f9a43a31fc367169001da..52d12825225cd0a337fc3215bb938fa8d75bacd4 100644
--- a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
+++ b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
@@ -363,14 +363,14 @@ AutotestPrivateGetVisibleNotificationsFunction::Run() {
#if defined(OS_CHROMEOS)
for (auto* notification :
message_center::MessageCenter::Get()->GetVisibleNotifications()) {
- base::DictionaryValue* result(new base::DictionaryValue);
+ std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
result->SetString("id", notification->id());
result->SetString("type", ConvertToString(notification->type()));
result->SetString("title", notification->title());
result->SetString("message", notification->message());
result->SetInteger("priority", notification->priority());
result->SetInteger("progress", notification->progress());
- values->Append(result);
+ values->Append(std::move(result));
}
#endif

Powered by Google App Engine
This is Rietveld 408576698