chrome/browser/chromeos/settings/owner_flags_storage.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/owner_flags_storage.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: headers Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/settings/owner_flags_storage.cc

diff --git a/chrome/browser/chromeos/settings/owner_flags_storage.cc b/chrome/browser/chromeos/settings/owner_flags_storage.cc

index 8b52ea83d5d37852ce633cf329dbbc96d7f4bfd3..d72e484d98d1fbb5966954079bb73520044dc367 100644

--- a/chrome/browser/chromeos/settings/owner_flags_storage.cc

+++ b/chrome/browser/chromeos/settings/owner_flags_storage.cc

@@ -37,7 +37,7 @@ bool OwnerFlagsStorage::SetFlags(const std::set<std::string>& flags) {

for (base::CommandLine::StringVector::const_iterator it =

switches.begin() + 1;

it != switches.end(); ++it) {

- experiments_list.Append(new base::StringValue(*it));

+ experiments_list.AppendString(*it);

}

owner_settings_service_->Set(kStartUpFlags, experiments_list);