Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chromeos/network/network_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_util.h"
 
 #include <stddef.h>
 
+#include <memory>
+#include <utility>
+
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 using chromeos::CellularScanResult;
 using chromeos::network_util::NetmaskToPrefixLength;
 using chromeos::network_util::PrefixLengthToNetmask;
 using chromeos::network_util::ParseCellularScanResults;
 
 typedef testing::Test NetworkUtilTest;
 
@@ skipping 92 matching lines @@
 
   // Empty list value.
   EXPECT_TRUE(ParseCellularScanResults(list, &scan_results));
 
   // List contains invalid item.
   list.AppendInteger(0);
   EXPECT_FALSE(ParseCellularScanResults(list, &scan_results));
 
   // Scan result has no network id.
   list.Clear();
-  base::DictionaryValue* dict_value = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> dict_value(
+      new base::DictionaryValue());
   dict_value->SetString(shill::kStatusProperty, "available");
-  list.Append(dict_value);
+  list.Append(std::move(dict_value));
   EXPECT_TRUE(ParseCellularScanResults(list, &scan_results));
   EXPECT_TRUE(scan_results.empty());
 
   // Mixed parse results.
-  dict_value = new base::DictionaryValue();
+  dict_value.reset(new base::DictionaryValue());
   dict_value->SetString(shill::kNetworkIdProperty, "000001");
   dict_value->SetString(shill::kStatusProperty, "unknown");
   dict_value->SetString(shill::kTechnologyProperty, "GSM");
-  list.Append(dict_value);
+  list.Append(std::move(dict_value));
 
-  dict_value = new base::DictionaryValue();
+  dict_value.reset(new base::DictionaryValue());
   dict_value->SetString(shill::kNetworkIdProperty, "000002");
   dict_value->SetString(shill::kStatusProperty, "available");
   dict_value->SetString(shill::kLongNameProperty, "Long Name");
-  list.Append(dict_value);
+  list.Append(std::move(dict_value));
 
   EXPECT_TRUE(ParseCellularScanResults(list, &scan_results));
   EXPECT_EQ(static_cast<size_t>(2), scan_results.size());
   EXPECT_EQ("000001", scan_results[0].network_id);
   EXPECT_EQ("unknown", scan_results[0].status);
   EXPECT_EQ("GSM", scan_results[0].technology);
   EXPECT_TRUE(scan_results[0].long_name.empty());
   EXPECT_TRUE(scan_results[0].short_name.empty());
 
   EXPECT_EQ("000002", scan_results[1].network_id);
   EXPECT_EQ("available", scan_results[1].status);
   EXPECT_EQ("Long Name", scan_results[1].long_name);
   EXPECT_TRUE(scan_results[1].short_name.empty());
   EXPECT_TRUE(scan_results[1].technology.empty());
 }