Remove TestWebKitPort from port_testcase.

Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.

Notes:

 - Previously, test_path_to_apache_config_file just tested the logic
   in the base Port class, but Port subclasses have different behavior,
   so more specific test methods could be added in test case subclasses.
 - The test_apache_config_file_name_for_platform method was testing
   behavior in the base Port class which didn't make sense to repeat
   for port subclasses, so I moved it to base_unittest.

Committed: https://crrev.com/70a7b38d071eab05a3afba41dabfae5ae5027c9c
Cr-Commit-Position: refs/heads/master@{#423679}

[qyearsley, 2016-10-05 20:43:22]

Description was changed from

==========
Start to remove TestWebKitPort (WIP)
==========

to

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code) and replaces
each use with different Port subclasses. For the most part this is
straightforward, except for a few test methods.
==========

[qyearsley, 2016-10-05 20:43:22]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-10-05 20:44:36]

Description was changed from

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code) and replaces
each use with different Port subclasses. For the most part this is
straightforward, except for a few test methods.
==========

to

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.

Notes:

 - Previously, test_path_to_apache_config_file just tested the logic in the base
Port class, but Port subclasses have different behavior, so more specific test
methods could be added in test case subclasses.
 - There were test_path_to_apache_c
==========

[qyearsley, 2016-10-05 20:46:19]

Description was changed from

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.

Notes:

 - Previously, test_path_to_apache_config_file just tested the logic in the base
Port class, but Port subclasses have different behavior, so more specific test
methods could be added in test case subclasses.
 - There were test_path_to_apache_c
==========

to

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.

Notes:

 - Previously, test_path_to_apache_config_file just tested the logic
   in the base Port class, but Port subclasses have different behavior,
   so more specific test methods could be added in test case subclasses.
 - The test_apache_config_file_name_for_platform method was testing
   behavior in the base Port class which didn't make sense to repeat
   for port subclasses, so I moved it to base_unittest.
==========

[qyearsley, 2016-10-06 00:01:10]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 00:02:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:53:57]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-10-06 17:48:58]

Mostly lgtm, but a couple of nits.

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
(right):

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py:660:
print self._host_port
is this change intentional?

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
(right):

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:363:
port.host.environ['WEBKIT_HTTP_SERVER_CONF_PATH'] = None
Setting the key to None isn't the same as deleting it. I'm not sure why you were
changing this line?

[qyearsley, 2016-10-06 20:15:43]

Thanks for taking a look (nits now fixed)

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
(right):

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py:660:
print self._host_port
On 2016/10/06 at 17:48:58, Dirk Pranke (slow) wrote:
> is this change intentional?

Nope! Now removed.

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
(right):

https://codereview.chromium.org/2392683003/diff/60001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:363:
port.host.environ['WEBKIT_HTTP_SERVER_CONF_PATH'] = None
On 2016/10/06 at 17:48:58, Dirk Pranke (slow) wrote:
> Setting the key to None isn't the same as deleting it. I'm not sure why you
were changing this line?

No particularly good reason; now changed back.

[qyearsley, 2016-10-06 20:17:46]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-10-06 20:17:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2392683003/#ps80001
(title: "Removed print; delete env var rather than setting to None")

[commit-bot: I haz the power, 2016-10-06 20:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:14:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-06 21:17:08]

Description was changed from

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.

Notes:

 - Previously, test_path_to_apache_config_file just tested the logic
   in the base Port class, but Port subclasses have different behavior,
   so more specific test methods could be added in test case subclasses.
 - The test_apache_config_file_name_for_platform method was testing
   behavior in the base Port class which didn't make sense to repeat
   for port subclasses, so I moved it to base_unittest.
==========

to

==========
Remove TestWebKitPort from port_testcase.

This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.

Notes:

 - Previously, test_path_to_apache_config_file just tested the logic
   in the base Port class, but Port subclasses have different behavior,
   so more specific test methods could be added in test case subclasses.
 - The test_apache_config_file_name_for_platform method was testing
   behavior in the base Port class which didn't make sense to repeat
   for port subclasses, so I moved it to base_unittest.

Committed: https://crrev.com/70a7b38d071eab05a3afba41dabfae5ae5027c9c
Cr-Commit-Position: refs/heads/master@{#423679}
==========

[commit-bot: I haz the power, 2016-10-06 21:17:09]

Patchset 5 (id:??) landed as
https://crrev.com/70a7b38d071eab05a3afba41dabfae5ae5027c9c
Cr-Commit-Position: refs/heads/master@{#423679}