Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2392673002: perform a null check in case WebContents doesn't have a ChromeDownloadDelegate (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perform a null check in case WebContents doesn't have a ChromeDownloadDelegate This could happen for Reader mode, as it generates a new webcontents. Enabling download on Reader mode will cause other issues like overwrite infobar. As a result, we should disable download in reader mode. Will work on removing the download button from media controller in reader mode. BUG=650738 Committed: https://crrev.com/ea10fd32a057ff0f991499641243a3781bc92d02 Cr-Commit-Position: refs/heads/master@{#422540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/android/download/download_controller.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 2 months ago (2016-10-03 19:36:20 UTC) #2
gone
lgtm
4 years, 2 months ago (2016-10-03 20:35:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392673002/1
4 years, 2 months ago (2016-10-03 20:45:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 21:35:13 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:37:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea10fd32a057ff0f991499641243a3781bc92d02
Cr-Commit-Position: refs/heads/master@{#422540}

Powered by Google App Engine
This is Rietveld 408576698