Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2392663004: Add swarm_presubmit recipe (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
dogben, borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add swarm_presubmit recipe This allows us to add a Housekeeper-PerCommit-Presubmit bot/trybot BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392663004 Committed: https://skia.googlesource.com/skia/+/93408df16e742f4e4cf0338beb189dca78196992

Patch Set 1 #

Patch Set 2 : No need to manually set persistent_checkout #

Patch Set 3 : Run 'git cl presubmit', not PRESUBMIT.py #

Total comments: 2

Patch Set 4 : Clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -72 lines) Patch
A + infra/bots/presubmit_skia.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download
M infra/bots/recipe_modules/vars/api.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + infra/bots/recipes/presubmit.expected/presubmit.json View 4 chunks +12 lines, -26 lines 0 comments Download
A infra/bots/recipes/swarm_presubmit.py View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_presubmit.expected/presubmit.json View 1 2 4 chunks +14 lines, -25 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 2 3 4 chunks +24 lines, -1 line 0 comments Download
A + infra/bots/recipes/swarm_trigger.expected/Housekeeper-PerCommit-Presubmit.json View 8 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
borenet
4 years, 2 months ago (2016-10-04 21:03:43 UTC) #3
borenet
Triggered locally: https://luci-milo.appspot.com/swarming/task/31aa4f332beecb10
4 years, 2 months ago (2016-10-04 21:04:39 UTC) #4
rmistry
lgtm https://codereview.chromium.org/2392663004/diff/40001/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2392663004/diff/40001/infra/bots/recipes/swarm_trigger.py#newcode725 infra/bots/recipes/swarm_trigger.py:725: 'Presubmit' not in builder)): This is a little ...
4 years, 2 months ago (2016-10-05 12:37:48 UTC) #5
borenet
https://codereview.chromium.org/2392663004/diff/40001/infra/bots/recipes/swarm_trigger.py File infra/bots/recipes/swarm_trigger.py (right): https://codereview.chromium.org/2392663004/diff/40001/infra/bots/recipes/swarm_trigger.py#newcode725 infra/bots/recipes/swarm_trigger.py:725: 'Presubmit' not in builder)): On 2016/10/05 12:37:47, rmistry wrote: ...
4 years, 2 months ago (2016-10-05 12:42:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392663004/60001
4 years, 2 months ago (2016-10-05 12:42:29 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:00:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/93408df16e742f4e4cf0338beb189dca78196992

Powered by Google App Engine
This is Rietveld 408576698