Issue 239263008: ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239263008: ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue (Closed)

Created:
6 years, 8 months ago by reni

Modified:
6 years, 8 months ago

Reviewers:
pdr.

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue SVG's styling properties like 'font-size' can not handle huge numbers represented by the 'inf' value and they make the assertion check fail. Simple CSS properties with such huge values are handled in CSSParser by setting them to zero. With this patch we apply this behaviour on SVG styling properties, too. The fix is based on WebKit changeset: http://trac.webkit.org/changeset/166114 (Patch by Martin Hodovan) R=pdr@chromium.org BUG=364031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171796

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
A +	LayoutTests/fast/css/infinite-floating-value.html	View	1 chunk	+4 lines, -3 lines	0 comments	Download
A +	LayoutTests/fast/css/infinite-floating-value-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/css/CSSValuePool.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/239263008/1

6 years, 8 months ago (2014-04-16 18:37:38 UTC) #4

Message was sent while issue was closed.

Change committed as 171796

Expand Messages | Collapse Messages