Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2392623003: Revert of Android: Free GLHelper context ashmem when it makes sense (Closed)

Created:
4 years, 2 months ago by boliu
Modified:
4 years, 2 months ago
Reviewers:
danakj, no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Free GLHelper context ashmem when it makes sense (patchset #4 id:60001 of https://codereview.chromium.org/2336043004/ ) Reason for revert: Causes a null pointer crash. And also apparently doesn't work? BUG=652050 Original issue's description: > Android: Free GLHelper context ashmem when it makes sense > > Free the 'mapped_memory' that is used in readbacks through > CopyFromCompositingSurface() when there is memory pressure > in the system (or no activities are running and a readback > completes). > > This memory gets lazily allocated during the first readback > and it'd be the size of the texture after scaling. Freeing it > is harmless at a slight reallocation cost when the next readback > is triggered. > > BUG=641962 > TBR=boliu@chromium.org > > Committed: https://crrev.com/98f7c133cdef22c26922c56371f84989f7a2cd60 > Cr-Commit-Position: refs/heads/master@{#421357} TBR=danakj@chromium.org,sievers@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=641962 Committed: https://crrev.com/4201167e8b04762db61cc037cc83537c298e2f53 Cr-Commit-Position: refs/heads/master@{#422574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -95 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 7 chunks +5 lines, -89 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of Android: Free GLHelper context ashmem when it makes sense
4 years, 2 months ago (2016-10-03 21:42:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392623003/1
4 years, 2 months ago (2016-10-03 21:43:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:43:24 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:45:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4201167e8b04762db61cc037cc83537c298e2f53
Cr-Commit-Position: refs/heads/master@{#422574}

Powered by Google App Engine
This is Rietveld 408576698