Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2392603005: Improvements to tools/gn.py (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improvements to tools/gn.py This change enables gn.py to take comma separated lists of modes, architectures, and os's similar to build.py. It also accepts 'all' for each of these just like build.py. GN is invoked in parallel to save time. This change also adds an option --gn to build.py to invoke ninja instead of the usual build system. Will investigate invoking tools/gn.py automagically from build.py in a future change. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/eabd4ed9fbf0ea1e2a69b38adb1daa32a435d993

Patch Set 1 #

Patch Set 2 : Fix mac toolchain for ios removal #

Patch Set 3 : Cleanup, better error reporting #

Patch Set 4 : Better script description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -135 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 2 chunks +0 lines, -27 lines 0 comments Download
M tools/build.py View 3 chunks +75 lines, -61 lines 0 comments Download
M tools/gn.py View 1 2 3 7 chunks +161 lines, -47 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 2 months ago (2016-10-04 22:48:06 UTC) #3
Cutch
lgtm
4 years, 2 months ago (2016-10-04 23:07:44 UTC) #4
zra
4 years, 2 months ago (2016-10-05 02:49:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
eabd4ed9fbf0ea1e2a69b38adb1daa32a435d993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698