Issue 23926012: Revert 221736 "[android] Adds constants.GetOutDirectory() and co..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23926012: Revert 221736 "[android] Adds constants.GetOutDirectory() and co..." (Closed)

Created:
7 years, 3 months ago by johnme

Modified:
7 years, 3 months ago

Reviewers:
craigdh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 221736 "[android] Adds constants.GetOutDirectory() and co..." Consistently causing WebKit Android (Nexus4) to fail provision_devices. > [android] Adds constants.GetOutDirectory() and converts test scripts to use it. > > BUG=260494 > TEST=None > NOTRY=True > > Review URL: https://chromiumcodereview.appspot.com/22903016 TBR=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222008

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -67 lines)			Patch
M	trunk/src/build/android/adb_install_apk.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/build/android/adb_reverse_forwarder.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/build/android/pylib/android_commands.py	View	3 chunks	+14 lines, -7 lines	0 comments	Download
M	trunk/src/build/android/pylib/base/base_test_runner.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/build/android/pylib/chrome_test_server_spawner.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/build/android/pylib/cmd_helper.py	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	trunk/src/build/android/pylib/constants.py	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	trunk/src/build/android/pylib/device_stats_monitor.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	trunk/src/build/android/pylib/fake_dns.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/build/android/pylib/forwarder.py	View	6 chunks	+24 lines, -12 lines	0 comments	Download
M	trunk/src/build/android/pylib/gtest/setup.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	trunk/src/build/android/pylib/gtest/test_package_apk.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	trunk/src/build/android/pylib/gtest/test_package_exe.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	trunk/src/build/android/pylib/host_driven/test_case.py	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/build/android/pylib/utils/report_results.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/chrome/test/functional/ispy/ispy_core/tools/reverse_port_forwarder.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/backends/adb_commands.py	View	4 chunks	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r222008.

Expand Messages | Collapse Messages