Rewrite Futures.

tests/lib/async/future_test.dart

Index: tests/lib/async/future_test.dart
diff --git a/tests/lib/async/future_test.dart b/tests/lib/async/future_test.dart
index 2c81f0558fd2cb7bafdc049cf40101b5998d3e82..15948322ea8dce4cd9023e300255ce5a1dd5253c 100644
--- a/tests/lib/async/future_test.dart
+++ b/tests/lib/async/future_test.dart
@@ -617,22 +617,6 @@ void testChainedFutureError() {
   completer.complete(21);
 }
 
-void testChainedFutureCycle() {
-  asyncStart();
-  var completer = new Completer();
-  var future, future2;
-  future  = completer.future.then((_) => future2);
-  future2 = completer.future.then((_) => future);
-  completer.complete(42);
-  int ctr = 2;
-  void receiveError(e) {
-    Expect.isTrue(e is StateError);
-    if (--ctr == 0) asyncEnd();
-  }
-  future.catchError(receiveError);
-  future.catchError(receiveError);
-}
-

[Lasse Reichstein Nielsen, 2013/09/10 12:03:53]

Why remove the test? Is it not correct any more?

[floitsch, 2013/09/10 17:19:14]

We don't catch cyclic chained futures anymore.

 main() {
   testValue();
   testSync();
@@ -674,5 +658,4 @@ main() {
   testChainedFutureValue();
   testChainedFutureValueDelay();
   testChainedFutureError();
-  testChainedFutureCycle();
 }