Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: Source/modules/webaudio/ConvolverNode.cpp

Issue 23926002: Fix threading races on ConvolverNode::m_reverb in ConvolverNode::tailTime() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 } 151 }
152 152
153 AudioBuffer* ConvolverNode::buffer() 153 AudioBuffer* ConvolverNode::buffer()
154 { 154 {
155 ASSERT(isMainThread()); 155 ASSERT(isMainThread());
156 return m_buffer.get(); 156 return m_buffer.get();
157 } 157 }
158 158
159 double ConvolverNode::tailTime() const 159 double ConvolverNode::tailTime() const
160 { 160 {
161 MutexLocker locker(m_processLock);
Raymond Toy 2013/09/04 16:18:14 I don't think we want to lock this way because tai
161 return m_reverb ? m_reverb->impulseResponseLength() / static_cast<double>(sa mpleRate()) : 0; 162 return m_reverb ? m_reverb->impulseResponseLength() / static_cast<double>(sa mpleRate()) : 0;
162 } 163 }
163 164
164 double ConvolverNode::latencyTime() const 165 double ConvolverNode::latencyTime() const
165 { 166 {
166 return m_reverb ? m_reverb->latencyFrames() / static_cast<double>(sampleRate ()) : 0; 167 return m_reverb ? m_reverb->latencyFrames() / static_cast<double>(sampleRate ()) : 0;
167 } 168 }
168 169
169 } // namespace WebCore 170 } // namespace WebCore
170 171
171 #endif // ENABLE(WEB_AUDIO) 172 #endif // ENABLE(WEB_AUDIO)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698