Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2392583002: Use FileDescriptorWatcher in UdevLinux (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in UdevLinux This allows UdevLinux to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/92ebb94ad1bdf0d4aef4f74240d4933a945e14d8 Cr-Commit-Position: refs/heads/master@{#422508}

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M device/udev_linux/udev_linux.h View 1 4 chunks +10 lines, -9 lines 0 comments Download
M device/udev_linux/udev_linux.cc View 1 4 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-03 19:53:01 UTC) #11
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-03 20:00:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392583002/20001
4 years, 2 months ago (2016-10-03 20:14:30 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 20:21:03 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:23:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92ebb94ad1bdf0d4aef4f74240d4933a945e14d8
Cr-Commit-Position: refs/heads/master@{#422508}

Powered by Google App Engine
This is Rietveld 408576698