Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2392573002: [MD Extensions] Add newlines between style rules in HTML (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dcheng, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Extensions] Add newlines between style rules in HTML Style [1] requires newlines between rules in CSS, but MD extensions haven't been abiding (my bad). Conform. [1] https://google.github.io/styleguide/htmlcssguide.xml?showone=Rule_Separation#Rule_Separation BUG=529395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1dc16e6bb2597678f122bed3a954ebc72819801e Cr-Commit-Position: refs/heads/master@{#422526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M chrome/browser/resources/md_extensions/detail_view.html View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_extensions/drop_overlay.html View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_extensions/keyboard_shortcuts.html View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_extensions/pack_dialog.html View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Devlin
4 years, 2 months ago (2016-10-03 17:11:37 UTC) #4
michaelpg
lgtm
4 years, 2 months ago (2016-10-03 20:29:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392573002/1
4 years, 2 months ago (2016-10-03 20:55:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 21:04:34 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:06:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dc16e6bb2597678f122bed3a954ebc72819801e
Cr-Commit-Position: refs/heads/master@{#422526}

Powered by Google App Engine
This is Rietveld 408576698