Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2392553002: Roll Syzygy DEPS to v0.8.21.0 (VS2015 build) (Closed)

Created:
4 years, 2 months ago by Sébastien Marchand
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Syzygy DEPS to v0.8.21.0 (VS2015 build) BUG= Committed: https://crrev.com/c537c6daa5b25f823e34e0359e15e0ccce019e7f Cr-Commit-Position: refs/heads/master@{#422895}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Sébastien Marchand
PTAL, it doesn't include the latest changes to fix the handling of the OOMs but ...
4 years, 2 months ago (2016-10-03 14:31:25 UTC) #2
chrisha
https://codereview.chromium.org/2392553002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2392553002/diff/1/DEPS#newcode931 DEPS:931: '--revision=734ae20be0862a6e1667f45d4fd4ceb2c430b2f6', Do you need to use your new flag, ...
4 years, 2 months ago (2016-10-03 19:51:11 UTC) #3
Sébastien Marchand
Ha, just realized that https://codereview.chromium.org/2365893002/ hasn't landed yet :/
4 years, 2 months ago (2016-10-03 19:54:03 UTC) #4
Sébastien Marchand
PTAnL.
4 years, 2 months ago (2016-10-04 18:57:30 UTC) #5
Sigurður Ásgeirsson
lgtm
4 years, 2 months ago (2016-10-04 19:04:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392553002/20001
4 years, 2 months ago (2016-10-04 19:07:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 20:08:50 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:11:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c537c6daa5b25f823e34e0359e15e0ccce019e7f
Cr-Commit-Position: refs/heads/master@{#422895}

Powered by Google App Engine
This is Rietveld 408576698