third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp - Issue 2392543004: Reflow comments in the Push and Notification modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

Issue 2392543004: Reflow comments in the Push and Notification modules. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/Notification.cpp ('K') | « third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

index 34404d22edacf07735b0c83eecfb8a872f6a9d1d..c86b1683cb63b5019f479e7b0bd5b4fe82f92206 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

@@ -21,8 +21,8 @@ const int kMaxApplicationServerKeyLength = 255;

String bufferSourceToString(

const ArrayBufferOrArrayBufferView& applicationServerKey,

ExceptionState& exceptionState) {

- // Check the validity of the sender info. It must be a 65 byte unencrypted key,

- // which has the byte 0x04 as the first byte as a marker.

+ // Check the validity of the sender info. It must be a 65-byte uncompressed

+ // key, which has the byte 0x04 as the first byte as a marker.

unsigned char* input;

int length;

if (applicationServerKey.isArrayBuffer()) {