third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp - Issue 2392543004: Reflow comments in the Push and Notification modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

Issue 2392543004: Reflow comments in the Push and Notification modules. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/Notification.cpp ('K') | « third_party/WebKit/Source/modules/notifications/NotificationEvent.h ('k') | third_party/WebKit/Source/modules/notifications/NotificationManager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

index 215d4a8c214d864e85a2787b956ea781352c2d8b..f9b66f779d5dfb4c0325b8f16840829216a15780 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

@@ -40,7 +40,8 @@ void NotificationImageLoader::start(

threadableLoaderOptions.preflightPolicy = PreventPreflight;

threadableLoaderOptions.crossOriginRequestPolicy = AllowCrossOriginRequests;

- // TODO(mvanouwerkerk): Add an entry for notifications to FetchInitiatorTypeNames and use it.

+ // TODO(mvanouwerkerk): Add an entry for notifications to

+ // FetchInitiatorTypeNames and use it.

ResourceLoaderOptions resourceLoaderOptions;

resourceLoaderOptions.allowCredentials = AllowStoredCredentials;

if (executionContext->isWorkerGlobalScope())