Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2392543004: Reflow comments in the Push and Notification modules. (Closed)

Created:
4 years, 2 months ago by Peter Beverloo
Modified:
4 years, 2 months ago
Reviewers:
harkness
CC:
chromium-reviews, awdf+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, haraken, blink-reviews, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in the Push and Notification modules. BUG= Committed: https://crrev.com/b31a822146111d8965d7c4c4884e9b9f71bccb80 Cr-Commit-Position: refs/heads/master@{#422811}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reflow comments in the Push and Notification modules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M third_party/WebKit/Source/modules/notifications/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushManager.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Peter Beverloo
+harkness
4 years, 2 months ago (2016-10-04 14:15:03 UTC) #2
harkness
LGTM https://codereview.chromium.org/2392543004/diff/1/third_party/WebKit/Source/modules/notifications/Notification.cpp File third_party/WebKit/Source/modules/notifications/Notification.cpp (right): https://codereview.chromium.org/2392543004/diff/1/third_party/WebKit/Source/modules/notifications/Notification.cpp#newcode221 third_party/WebKit/Source/modules/notifications/Notification.cpp:221: // The notification should be Showing when the ...
4 years, 2 months ago (2016-10-04 14:31:16 UTC) #5
Peter Beverloo
Thanks! https://codereview.chromium.org/2392543004/diff/1/third_party/WebKit/Source/modules/notifications/Notification.cpp File third_party/WebKit/Source/modules/notifications/Notification.cpp (right): https://codereview.chromium.org/2392543004/diff/1/third_party/WebKit/Source/modules/notifications/Notification.cpp#newcode221 third_party/WebKit/Source/modules/notifications/Notification.cpp:221: // The notification should be Showing when the ...
4 years, 2 months ago (2016-10-04 14:38:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392543004/20001
4 years, 2 months ago (2016-10-04 14:38:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 15:45:34 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 15:48:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b31a822146111d8965d7c4c4884e9b9f71bccb80
Cr-Commit-Position: refs/heads/master@{#422811}

Powered by Google App Engine
This is Rietveld 408576698