Issue 239253003: Stop using v8::Persistent in ObjectBackedNativeHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239253003: Stop using v8::Persistent in ObjectBackedNativeHandler (Closed)

Created:
6 years, 8 months ago by adamk

Modified:
6 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit), not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dcarney, vogelheim

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Stop using v8::Persistent in ObjectBackedNativeHandler When r261795 switched from storing UnsafePersistents to using the new PersistentValueVector, the allocation of a v8::Persistent was erroneously left in the code, and would never be disposed. As it happens, that Persistent isn't needed at all, so avoiding the memory leak is just a matter of never allocating it. R=jochen@chromium.org BUG=363708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264059