Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2392503003: Fix LayoutBox::topLeftLocation for table rows and table cells (Closed)
Patch Set: virtual Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 LayoutSize size() const { return m_frameRect.size(); } 319 LayoutSize size() const { return m_frameRect.size(); }
320 IntSize pixelSnappedSize() const { return m_frameRect.pixelSnappedSize(); } 320 IntSize pixelSnappedSize() const { return m_frameRect.pixelSnappedSize(); }
321 321
322 void setLocation(const LayoutPoint& location) { 322 void setLocation(const LayoutPoint& location) {
323 if (location == m_frameRect.location()) 323 if (location == m_frameRect.location())
324 return; 324 return;
325 m_frameRect.setLocation(location); 325 m_frameRect.setLocation(location);
326 frameRectChanged(); 326 frameRectChanged();
327 } 327 }
328 328
329 // The ancestor box that this object's location and topLeftLocation are
330 // relative to.
331 virtual LayoutBox* locationContainer() const;
332
329 // FIXME: Currently scrollbars are using int geometry and positioned based on 333 // FIXME: Currently scrollbars are using int geometry and positioned based on
330 // pixelSnappedBorderBoxRect whose size may change when location changes becau se of 334 // pixelSnappedBorderBoxRect whose size may change when location changes becau se of
331 // pixel snapping. This function is used to change location of the LayoutBox o utside 335 // pixel snapping. This function is used to change location of the LayoutBox o utside
332 // of LayoutBox::layout(). Will remove when we use LayoutUnits for scrollbars. 336 // of LayoutBox::layout(). Will remove when we use LayoutUnits for scrollbars.
333 void setLocationAndUpdateOverflowControlsIfNeeded(const LayoutPoint&); 337 void setLocationAndUpdateOverflowControlsIfNeeded(const LayoutPoint&);
334 338
335 void setSize(const LayoutSize& size) { 339 void setSize(const LayoutSize& size) {
336 if (size == m_frameRect.size()) 340 if (size == m_frameRect.size())
337 return; 341 return;
338 m_frameRect.setSize(size); 342 m_frameRect.setSize(size);
(...skipping 1238 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 1581
1578 inline bool LayoutBox::isForcedFragmentainerBreakValue(EBreak breakValue) { 1582 inline bool LayoutBox::isForcedFragmentainerBreakValue(EBreak breakValue) {
1579 return breakValue == BreakColumn || breakValue == BreakLeft || 1583 return breakValue == BreakColumn || breakValue == BreakLeft ||
1580 breakValue == BreakPage || breakValue == BreakRecto || 1584 breakValue == BreakPage || breakValue == BreakRecto ||
1581 breakValue == BreakRight || breakValue == BreakVerso; 1585 breakValue == BreakRight || breakValue == BreakVerso;
1582 } 1586 }
1583 1587
1584 } // namespace blink 1588 } // namespace blink
1585 1589
1586 #endif // LayoutBox_h 1590 #endif // LayoutBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698