Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chromeos/dbus/cros_disks_client.h

Issue 2392503002: Allow to pass remount option to Mount method of cros_disks_client. (Closed)
Patch Set: Sync to head. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/cros_disks_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/cros_disks_client.h
diff --git a/chromeos/dbus/cros_disks_client.h b/chromeos/dbus/cros_disks_client.h
index c6e2f971bcb9273f8b49de993fe186c83f12238a..ec951e4ca218843ecca39e33567babb99e925926 100644
--- a/chromeos/dbus/cros_disks_client.h
+++ b/chromeos/dbus/cros_disks_client.h
@@ -108,6 +108,12 @@ enum MountAccessMode {
MOUNT_ACCESS_MODE_READ_ONLY,
};
+// Whether to mount to a new path or remount an existing one.
hashimoto 2016/10/19 08:46:23 What does "remount an existing one" mean? Please c
yamaguchi1 2016/10/19 10:34:10 Revised the comments. I made it this way to minimi
+enum RemountOption {
+ REMOUNT_OPTION_DISABLED,
+ REMOUNT_OPTION_ENABLED,
+};
+
// A class to represent information about a disk sent from cros-disks.
class CHROMEOS_EXPORT DiskInfo {
public:
@@ -278,6 +284,7 @@ class CHROMEOS_EXPORT CrosDisksClient : public DBusClient {
const std::string& source_format,
const std::string& mount_label,
MountAccessMode access_mode,
+ RemountOption remount,
const base::Closure& callback,
const base::Closure& error_callback) = 0;
@@ -341,7 +348,8 @@ class CHROMEOS_EXPORT CrosDisksClient : public DBusClient {
// Composes a list of mount options.
static std::vector<std::string> ComposeMountOptions(
const std::string& mount_label,
- MountAccessMode access_mode);
+ MountAccessMode access_mode,
+ RemountOption remount);
protected:
// Create() should be used instead.
« no previous file with comments | « no previous file | chromeos/dbus/cros_disks_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698